`IBulkProcessingAction::executeAction()` throws `\InvalidArgumentException`

diff --git a/wcfsetup/install/files/lib/system/bulk/processing/IBulkProcessingAction.class.php b/wcfsetup/install/files/lib/system/bulk/processing/IBulkProcessingAction.class.php
index 4fc7ee52f620ebe09dc59575f3d15d1fa433b6a7..98f091cd283813e4638007b873676636270edca7 100644 (file)
--- a/wcfsetup/install/files/lib/system/bulk/processing/IBulkProcessingAction.class.php
+++ b/wcfsetup/install/files/lib/system/bulk/processing/IBulkProcessingAction.class.php
@@ -17,6 +17,7 @@ interface IBulkProcessingAction {
         * list.
         * 
         * @param       DatabaseObjectList      $objectList
+        * @throws      \InvalidArgumentException       if given object list cannot be handled by the action
         */
        public function executeAction(DatabaseObjectList $objectList);
        

diff --git a/wcfsetup/install/files/lib/system/bulk/processing/user/AbstractUserGroupsUserBulkProcessingAction.class.php b/wcfsetup/install/files/lib/system/bulk/processing/user/AbstractUserGroupsUserBulkProcessingAction.class.php
index a16388bc1767f91d84acf20af52d60368e25202e..7c9743c94da95763e4c128b41784d33068ec1cb8 100644 (file)
--- a/wcfsetup/install/files/lib/system/bulk/processing/user/AbstractUserGroupsUserBulkProcessingAction.class.php
+++ b/wcfsetup/install/files/lib/system/bulk/processing/user/AbstractUserGroupsUserBulkProcessingAction.class.php
@@ -56,7 +56,9 @@ abstract class AbstractUserGroupsUserBulkProcessingAction extends AbstractUserBu
         * @inheritDoc
         */
        public function executeAction(DatabaseObjectList $objectList) {
-               if (!($objectList instanceof UserList)) return;
+               if (!($objectList instanceof UserList)) {
+                       throw new \InvalidArgumentException("Object list is no instance of '".UserList::class."', instance of '".get_class($objectList)."' given.");
+               }
                
                $users = $this->getAccessibleUsers($objectList);
                

diff --git a/wcfsetup/install/files/lib/system/bulk/processing/user/DeleteUserBulkProcessingAction.class.php b/wcfsetup/install/files/lib/system/bulk/processing/user/DeleteUserBulkProcessingAction.class.php
index 477ed7ff6bfb7a669c63fae719ba51396d66364e..5b6c09f412877e1fbe95907d1ce5c5b9c7fb53ba 100644 (file)
--- a/wcfsetup/install/files/lib/system/bulk/processing/user/DeleteUserBulkProcessingAction.class.php
+++ b/wcfsetup/install/files/lib/system/bulk/processing/user/DeleteUserBulkProcessingAction.class.php
@@ -19,7 +19,9 @@ class DeleteUserBulkProcessingAction extends AbstractUserBulkProcessingAction {
         * @inheritDoc
         */
        public function executeAction(DatabaseObjectList $objectList) {
-               if (!($objectList instanceof UserList)) return;
+               if (!($objectList instanceof UserList)) {
+                       throw new \InvalidArgumentException("Object list is no instance of '".UserList::class."', instance of '".get_class($objectList)."' given.");
+               }
                
                $users = $this->getAccessibleUsers($objectList);
                

diff --git a/wcfsetup/install/files/lib/system/bulk/processing/user/ExportMailAddressUserBulkProcessingAction.class.php b/wcfsetup/install/files/lib/system/bulk/processing/user/ExportMailAddressUserBulkProcessingAction.class.php
index bdf6ce6a3fefb1d76948b189ed328ee586a033e7..80bff96a7e43dcfce582e7e880e58a5a55d2d337 100644 (file)
--- a/wcfsetup/install/files/lib/system/bulk/processing/user/ExportMailAddressUserBulkProcessingAction.class.php
+++ b/wcfsetup/install/files/lib/system/bulk/processing/user/ExportMailAddressUserBulkProcessingAction.class.php
@@ -37,7 +37,9 @@ class ExportMailAddressUserBulkProcessingAction extends AbstractUserBulkProcessi
         * @inheritDoc
         */
        public function executeAction(DatabaseObjectList $objectList) {
-               if (!($objectList instanceof UserList)) return;
+               if (!($objectList instanceof UserList)) {
+                       throw new \InvalidArgumentException("Object list is no instance of '".UserList::class."', instance of '".get_class($objectList)."' given.");
+               }
                
                // send content type
                header('Content-Type: text/'.$this->fileType.'; charset=UTF-8');

diff --git a/wcfsetup/install/files/lib/system/bulk/processing/user/SendMailUserBulkProcessingAction.class.php b/wcfsetup/install/files/lib/system/bulk/processing/user/SendMailUserBulkProcessingAction.class.php
index fe1077fd6c941c2bbe881318765db4966f0aa0eb..773a113986d24e2b6702ded22bfe19da31a9bffa 100644 (file)
--- a/wcfsetup/install/files/lib/system/bulk/processing/user/SendMailUserBulkProcessingAction.class.php
+++ b/wcfsetup/install/files/lib/system/bulk/processing/user/SendMailUserBulkProcessingAction.class.php
@@ -50,7 +50,9 @@ class SendMailUserBulkProcessingAction extends AbstractUserBulkProcessingAction
         * @inheritDoc
         */
        public function executeAction(DatabaseObjectList $objectList) {
-               if (!($objectList instanceof UserList)) return;
+               if (!($objectList instanceof UserList)) {
+                       throw new \InvalidArgumentException("Object list is no instance of '".UserList::class."', instance of '".get_class($objectList)."' given.");
+               }
                
                if (count($objectList)) {
                        // save config in session