[media] tm6000: check an allocation for failure
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 30 Jan 2013 06:03:43 +0000 (03:03 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Fri, 8 Feb 2013 16:46:56 +0000 (14:46 -0200)
This allocation had no error checking.  It didn't need to be under
the mutex so I moved it out form there. That makes the error handling
easier and is a potential speed up.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/usb/tm6000/tm6000-core.c

index 22cc0116deb65e9f9e26f8b2ba844c778d6a5c57..7c32353c59db3db240d82296f3b4e5536ade0dd0 100644 (file)
@@ -40,10 +40,13 @@ int tm6000_read_write_usb(struct tm6000_core *dev, u8 req_type, u8 req,
        u8           *data = NULL;
        int delay = 5000;
 
-       mutex_lock(&dev->usb_lock);
-
-       if (len)
+       if (len) {
                data = kzalloc(len, GFP_KERNEL);
+               if (!data)
+                       return -ENOMEM;
+       }
+
+       mutex_lock(&dev->usb_lock);
 
        if (req_type & USB_DIR_IN)
                pipe = usb_rcvctrlpipe(dev->udev, 0);