usb: renesas_usbhs: Add access control for INTSTS1 and INTENB1 register
authorNobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Fri, 9 Jan 2015 00:28:41 +0000 (09:28 +0900)
committerFelipe Balbi <balbi@ti.com>
Thu, 14 May 2015 14:56:09 +0000 (09:56 -0500)
INTSTS1 and INTENB1 register of renesas_usbhs can access only Host mode.
This adds process of accessing INTSTS1 and INTENB1 only when renesas_usbhs
is Host mode.

Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/renesas_usbhs/mod.c

index 9a705b15b3a1528b733c9eebac04e0d2f7ef2ee9..e5ce6e6d4f51bbc11153a844960dd692ac1516c0 100644 (file)
@@ -218,10 +218,12 @@ static int usbhs_status_get_each_irq(struct usbhs_priv *priv,
        /********************  spin lock ********************/
        usbhs_lock(priv, flags);
        state->intsts0 = usbhs_read(priv, INTSTS0);
-       state->intsts1 = usbhs_read(priv, INTSTS1);
-
        intenb0 = usbhs_read(priv, INTENB0);
-       intenb1 = usbhs_read(priv, INTENB1);
+
+       if (usbhs_mod_is_host(priv)) {
+               state->intsts1 = usbhs_read(priv, INTSTS1);
+               intenb1 = usbhs_read(priv, INTENB1);
+       }
 
        /* mask */
        if (mod) {
@@ -275,7 +277,8 @@ static irqreturn_t usbhs_interrupt(int irq, void *data)
         *         - Function :: VALID bit should 0
         */
        usbhs_write(priv, INTSTS0, ~irq_state.intsts0 & INTSTS0_MAGIC);
-       usbhs_write(priv, INTSTS1, ~irq_state.intsts1 & INTSTS1_MAGIC);
+       if (usbhs_mod_is_host(priv))
+               usbhs_write(priv, INTSTS1, ~irq_state.intsts1 & INTSTS1_MAGIC);
 
        usbhs_write(priv, BRDYSTS, ~irq_state.brdysts);
        usbhs_write(priv, NRDYSTS, ~irq_state.nrdysts);
@@ -303,19 +306,20 @@ static irqreturn_t usbhs_interrupt(int irq, void *data)
        if (irq_state.intsts0 & BRDY)
                usbhs_mod_call(priv, irq_ready, priv, &irq_state);
 
-       /* INTSTS1 */
-       if (irq_state.intsts1 & ATTCH)
-               usbhs_mod_call(priv, irq_attch, priv, &irq_state);
-
-       if (irq_state.intsts1 & DTCH)
-               usbhs_mod_call(priv, irq_dtch, priv, &irq_state);
+       if (usbhs_mod_is_host(priv)) {
+               /* INTSTS1 */
+               if (irq_state.intsts1 & ATTCH)
+                       usbhs_mod_call(priv, irq_attch, priv, &irq_state);
 
-       if (irq_state.intsts1 & SIGN)
-               usbhs_mod_call(priv, irq_sign, priv, &irq_state);
+               if (irq_state.intsts1 & DTCH)
+                       usbhs_mod_call(priv, irq_dtch, priv, &irq_state);
 
-       if (irq_state.intsts1 & SACK)
-               usbhs_mod_call(priv, irq_sack, priv, &irq_state);
+               if (irq_state.intsts1 & SIGN)
+                       usbhs_mod_call(priv, irq_sign, priv, &irq_state);
 
+               if (irq_state.intsts1 & SACK)
+                       usbhs_mod_call(priv, irq_sack, priv, &irq_state);
+       }
        return IRQ_HANDLED;
 }
 
@@ -334,7 +338,8 @@ void usbhs_irq_callback_update(struct usbhs_priv *priv, struct usbhs_mod *mod)
         *  - update INTSTS0
         */
        usbhs_write(priv, INTENB0, 0);
-       usbhs_write(priv, INTENB1, 0);
+       if (usbhs_mod_is_host(priv))
+               usbhs_write(priv, INTENB1, 0);
 
        usbhs_write(priv, BEMPENB, 0);
        usbhs_write(priv, BRDYENB, 0);
@@ -368,25 +373,27 @@ void usbhs_irq_callback_update(struct usbhs_priv *priv, struct usbhs_mod *mod)
                        intenb0 |= BRDYE;
                }
 
-               /*
-                * INTSTS1
-                */
-               if (mod->irq_attch)
-                       intenb1 |= ATTCHE;
+               if (usbhs_mod_is_host(priv)) {
+                       /*
+                        * INTSTS1
+                        */
+                       if (mod->irq_attch)
+                               intenb1 |= ATTCHE;
 
-               if (mod->irq_dtch)
-                       intenb1 |= DTCHE;
+                       if (mod->irq_dtch)
+                               intenb1 |= DTCHE;
 
-               if (mod->irq_sign)
-                       intenb1 |= SIGNE;
+                       if (mod->irq_sign)
+                               intenb1 |= SIGNE;
 
-               if (mod->irq_sack)
-                       intenb1 |= SACKE;
+                       if (mod->irq_sack)
+                               intenb1 |= SACKE;
+               }
        }
 
        if (intenb0)
                usbhs_write(priv, INTENB0, intenb0);
 
-       if (intenb1)
+       if (usbhs_mod_is_host(priv) && intenb1)
                usbhs_write(priv, INTENB1, intenb1);
 }