drivers/net: Use RCU_INIT_POINTER(x, NULL) in bonding/bond_options.c
authorMonam Agarwal <monamagarwal123@gmail.com>
Sun, 23 Mar 2014 18:30:17 +0000 (00:00 +0530)
committerDavid S. Miller <davem@davemloft.net>
Thu, 27 Mar 2014 04:18:09 +0000 (00:18 -0400)
This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)

The rcu_assign_pointer() ensures that the initialization of a structure
is carried out before storing a pointer to that structure.
And in the case of the NULL pointer, there is no structure to initialize.
So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bonding/bond_options.c

index 6e6b09359ec35479d604db91e28b5c91c5a95708..724e30fa20b9fa70166b5d9b25ed9029fab6db73 100644 (file)
@@ -712,7 +712,7 @@ static int bond_option_active_slave_set(struct bonding *bond,
        /* check to see if we are clearing active */
        if (!slave_dev) {
                pr_info("%s: Clearing current active slave\n", bond->dev->name);
-               rcu_assign_pointer(bond->curr_active_slave, NULL);
+               RCU_INIT_POINTER(bond->curr_active_slave, NULL);
                bond_select_active_slave(bond);
        } else {
                struct slave *old_active = bond->curr_active_slave;