UBI: fix error path in __wl_get_peb
authorTanya Brokhman <tlinder@codeaurora.org>
Tue, 1 Apr 2014 08:01:12 +0000 (11:01 +0300)
committerArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
Mon, 5 May 2014 06:31:33 +0000 (09:31 +0300)
In case of an error (if there are not free PEB's for example),
__wl_get_peb will return a negative value. In order to prevent access
violation we need to test the returned value prior to using it later on.

Signed-off-by: Tatyana Brokhman <tlinder@codeaurora.org>
Reviewed-by: Dolev Raviv <draviv@codeaurora.org>
Acked-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
drivers/mtd/ubi/wl.c

index 02317c1c02385914c94175fa8757089c677e2b94..457ead32105cb5d1227725c3c5ecba0b6438612c 100644 (file)
@@ -684,6 +684,9 @@ int ubi_wl_get_peb(struct ubi_device *ubi)
        peb = __wl_get_peb(ubi);
        spin_unlock(&ubi->wl_lock);
 
+       if (peb < 0)
+               return peb;
+
        err = ubi_self_check_all_ff(ubi, peb, ubi->vid_hdr_aloffset,
                                    ubi->peb_size - ubi->vid_hdr_aloffset);
        if (err) {