openvswitch: Add a missing break statement.
authorJarno Rajahalme <jarno@ovn.org>
Tue, 20 Dec 2016 01:06:33 +0000 (17:06 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 20 Dec 2016 19:07:41 +0000 (14:07 -0500)
Add a break statement to prevent fall-through from
OVS_KEY_ATTR_ETHERNET to OVS_KEY_ATTR_TUNNEL.  Without the break
actions setting ethernet addresses fail to validate with log messages
complaining about invalid tunnel attributes.

Fixes: 0a6410fbde ("openvswitch: netlink: support L3 packets")
Signed-off-by: Jarno Rajahalme <jarno@ovn.org>
Acked-by: Pravin B Shelar <pshelar@ovn.org>
Acked-by: Jiri Benc <jbenc@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/openvswitch/flow_netlink.c

index d19044f2b1f4d1216ec7a4f25eaabecbf99c6214..c87d359b9b37a07711c65e61a1cb882148f76ee0 100644 (file)
@@ -2195,6 +2195,7 @@ static int validate_set(const struct nlattr *a,
        case OVS_KEY_ATTR_ETHERNET:
                if (mac_proto != MAC_PROTO_ETHERNET)
                        return -EINVAL;
+               break;
 
        case OVS_KEY_ATTR_TUNNEL:
                if (masked)