net: can: usb: ems_usb: don't print error when allocating urb fails
authorWolfram Sang <wsa-dev@sang-engineering.com>
Thu, 11 Aug 2016 21:05:20 +0000 (23:05 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sat, 13 Aug 2016 21:53:38 +0000 (14:53 -0700)
kmalloc will print enough information in case of failure.

Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/can/usb/ems_usb.c

index 71f0e791355b9c6e51218c6829a89cbc17ba607f..b3d02759c226bbde64ea3bdcdd3314ca646b743b 100644 (file)
@@ -600,7 +600,6 @@ static int ems_usb_start(struct ems_usb *dev)
                /* create a URB, and a buffer for it */
                urb = usb_alloc_urb(0, GFP_KERNEL);
                if (!urb) {
-                       netdev_err(netdev, "No memory left for URBs\n");
                        err = -ENOMEM;
                        break;
                }
@@ -752,10 +751,8 @@ static netdev_tx_t ems_usb_start_xmit(struct sk_buff *skb, struct net_device *ne
 
        /* create a URB, and a buffer for it, and copy the data to the URB */
        urb = usb_alloc_urb(0, GFP_ATOMIC);
-       if (!urb) {
-               netdev_err(netdev, "No memory left for URBs\n");
+       if (!urb)
                goto nomem;
-       }
 
        buf = usb_alloc_coherent(dev->udev, size, GFP_ATOMIC, &urb->transfer_dma);
        if (!buf) {
@@ -1007,10 +1004,8 @@ static int ems_usb_probe(struct usb_interface *intf,
                dev->tx_contexts[i].echo_index = MAX_TX_URBS;
 
        dev->intr_urb = usb_alloc_urb(0, GFP_KERNEL);
-       if (!dev->intr_urb) {
-               dev_err(&intf->dev, "Couldn't alloc intr URB\n");
+       if (!dev->intr_urb)
                goto cleanup_candev;
-       }
 
        dev->intr_in_buffer = kzalloc(INTR_IN_BUFFER_SIZE, GFP_KERNEL);
        if (!dev->intr_in_buffer)