Apply suggestions from code review

Co-authored-by: Alexander Ebert <ebert@woltlab.com>

diff --git a/ts/WoltLabSuite/Core/Form/Builder/Field/Controller/FileProcessor.ts b/ts/WoltLabSuite/Core/Form/Builder/Field/Controller/FileProcessor.ts
index b4fd565ca6eef3fbf5659f41f9e82df8527b2e77..291a68fbabd1aaea3f26c6bc7aad261a5dc97056 100644 (file)
--- a/ts/WoltLabSuite/Core/Form/Builder/Field/Controller/FileProcessor.ts
+++ b/ts/WoltLabSuite/Core/Form/Builder/Field/Controller/FileProcessor.ts
@@ -17,7 +17,8 @@ import {
 } from "WoltLabSuite/Core/Component/File/File";
 import { clearPreviousErrors } from "WoltLabSuite/Core/Component/File/Upload";
 
-const _data = new Map<string, FileProcessor>();
+type FileId = string;
+const fileProcessors = new Map<FieldId, FileProcessor>();
 
 export interface ExtraButton {
   title: string;

diff --git a/wcfsetup/install/files/lib/system/file/processor/FileProcessor.class.php b/wcfsetup/install/files/lib/system/file/processor/FileProcessor.class.php
index d770ef4ff8c0af6dc34b84753d1073954091a2ae..d38534d8b9800e2a4b01556c2675c4dfe619880b 100644 (file)
--- a/wcfsetup/install/files/lib/system/file/processor/FileProcessor.class.php
+++ b/wcfsetup/install/files/lib/system/file/processor/FileProcessor.class.php
@@ -240,8 +240,8 @@ final class FileProcessor extends SingletonFactory
 
     public function hasReachedUploadLimit(IFileProcessor $fileProcessor, array $context): bool
     {
-        // Replace button from `FileProcessorFormField` is clicked.
-        if (!empty($context["__replace"])) {
+        $isReplacement = $context['__replace'] ?? false;
+        if ($isReplacement) {
             return false;
         }