ALSA: asihpi: Deletion of an unnecessary check before the function call "vfree"
authorMarkus Elfring <elfring@users.sourceforge.net>
Tue, 2 Dec 2014 17:05:32 +0000 (18:05 +0100)
committerTakashi Iwai <tiwai@suse.de>
Tue, 2 Dec 2014 17:39:30 +0000 (18:39 +0100)
The vfree() function performs also input parameter validation. Thus the test
around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/asihpi/hpioctl.c

index e457eb80658bf027fb7aeef5bbbe871109056c00..6aa677e60555723058acb4a8c0a9cdc5deb17aa5 100644 (file)
@@ -547,8 +547,7 @@ void asihpi_adapter_remove(struct pci_dev *pci_dev)
        if (pa->irq)
                free_irq(pa->irq, pa);
 
-       if (pa->p_buffer)
-               vfree(pa->p_buffer);
+       vfree(pa->p_buffer);
 
        if (1)
                dev_info(&pci_dev->dev,