drivers/edac/i3000: document type promotion
authorJason Uhlenkott <juhlenko@akamai.com>
Thu, 7 Feb 2008 08:15:05 +0000 (00:15 -0800)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Thu, 7 Feb 2008 16:42:23 +0000 (08:42 -0800)
By popular request, add a comment documenting the implicit type promotion
here.

Signed-off-by: Jason Uhlenkott <juhlenko@akamai.com>
Signed-off-by: Doug Thompson <dougthompson@xmission.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/edac/i3000_edac.c

index b813f356b3906bd7a79ea673b27c9fc5e9dab8f1..5d4292811c146285f45acc0f47ebe0618d210127 100644 (file)
                                 */
 #define I3000_DEAP_GRAIN               (1 << 7)
 
+/*
+ * Helper functions to decode the DEAP/EDEAP hardware registers.
+ *
+ * The type promotion here is deliberate; we're deriving an
+ * unsigned long pfn and offset from hardware regs which are u8/u32.
+ */
+
 static inline unsigned long deap_pfn(u8 edeap, u32 deap)
 {
        deap >>= PAGE_SHIFT;