sparc64: Flush TLB before releasing pages.
authorDavid S. Miller <davem@davemloft.net>
Thu, 26 Mar 2009 08:54:46 +0000 (01:54 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 26 Mar 2009 08:54:46 +0000 (01:54 -0700)
tlb_flush_mmu() needs to flush pending TLB entries before
processing the mmu_gather ->pages list.

Noticed by Benjamin Herrenschmidt.

Signed-off-by: David S. Miller <davem@davemloft.net>
arch/sparc/include/asm/tlb_64.h

index ec81cdedef2c8a94aaea03263371b19c832edf60..ee38e731bfa635587afd73bac991fa69fad8ebec 100644 (file)
@@ -57,6 +57,8 @@ static inline struct mmu_gather *tlb_gather_mmu(struct mm_struct *mm, unsigned i
 
 static inline void tlb_flush_mmu(struct mmu_gather *mp)
 {
+       if (!mp->fullmm)
+               flush_tlb_pending();
        if (mp->need_flush) {
                free_pages_and_swap_cache(mp->pages, mp->pages_nr);
                mp->pages_nr = 0;
@@ -78,8 +80,6 @@ static inline void tlb_finish_mmu(struct mmu_gather *mp, unsigned long start, un
 
        if (mp->fullmm)
                mp->fullmm = 0;
-       else
-               flush_tlb_pending();
 
        /* keep the page table cache within bounds */
        check_pgt_cache();