stmmac: Remove spin_lock call in stmmac_get_pauseparam()
authorEmil Goode <emilgoode@gmail.com>
Mon, 2 Jun 2014 09:30:50 +0000 (11:30 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 2 Jun 2014 17:38:14 +0000 (10:38 -0700)
The following patch removed unnecessary spin_lock/unlock calls
in ethtool_ops callback functions. In the second and final version
of the patch one spin_lock call was left behind.

commit cab6715c3e8029e98b0b5d4056ceda007c0f6380
Author: Yang Wei <Wei.Yang@windriver.com>
Date:   Sun May 25 09:53:44 2014 +0800

    net: driver: stmicro: Remove some useless the lock protection

This introduced the following sparse warning:

drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:424:1: warning:
context imbalance in 'stmmac_get_pauseparam' -
different lock contexts for basic block

Signed-off-by: Emil Goode <emilgoode@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c

index 78926662d58cb7e86dc84c9962f12ffc323c212b..c62e67f3c2f0692f85b39c42a69de3fc5ed37b22 100644 (file)
@@ -429,8 +429,6 @@ stmmac_get_pauseparam(struct net_device *netdev,
        if (priv->pcs)  /* FIXME */
                return;
 
-       spin_lock(&priv->lock);
-
        pause->rx_pause = 0;
        pause->tx_pause = 0;
        pause->autoneg = priv->phydev->autoneg;