can: ti_hecc: Fix uninitialized spinlock in probe
authorAbhilash K V <abhilash.kv@ti.com>
Tue, 23 Aug 2011 03:05:57 +0000 (03:05 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 26 Aug 2011 16:48:24 +0000 (12:48 -0400)
In ti_hecc_probe(), the spinlock  priv->mbx_lock is not
inited, causing a spinlock lockup BUG.

Acked-by: Anant Gole <anantgole@ti.com>
Signed-off-by: Abhilash K V <abhilash.kv@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/can/ti_hecc.c

index 0b19a17d81783218ff9bba3f1e5a1853b0430c58..a81249246eceeefbf385853ad149eb54a0094e10 100644 (file)
@@ -923,6 +923,7 @@ static int ti_hecc_probe(struct platform_device *pdev)
        priv->can.do_get_state = ti_hecc_get_state;
        priv->can.ctrlmode_supported = CAN_CTRLMODE_3_SAMPLES;
 
+       spin_lock_init(&priv->mbx_lock);
        ndev->irq = irq->start;
        ndev->flags |= IFF_ECHO;
        platform_set_drvdata(pdev, ndev);