drivers/net/mlx4: Adjust constant
authorJulia Lawall <julia@diku.dk>
Sun, 19 Jul 2009 06:09:25 +0000 (06:09 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 21 Jul 2009 20:00:46 +0000 (13:00 -0700)
The values in the advertising field are typically ADVERTISED_xxx, not
SUPPORTED_xxx.  Both SUPPORTED_10000baseT_Full and
ADVERTISED_1000baseT_Full have the same value.

The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
struct ethtool_cmd E;
@@
*E.advertising = SUPPORTED_10000baseT_Full
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/mlx4/en_ethtool.c

index 091f99052c91673f4536004e885cdebca05f598c..86467b444ac679ab4b4a62e25aaba29c38d12bf2 100644 (file)
@@ -220,7 +220,7 @@ static int mlx4_en_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
 {
        cmd->autoneg = AUTONEG_DISABLE;
        cmd->supported = SUPPORTED_10000baseT_Full;
-       cmd->advertising = SUPPORTED_10000baseT_Full;
+       cmd->advertising = ADVERTISED_1000baseT_Full;
        if (netif_carrier_ok(dev)) {
                cmd->speed = SPEED_10000;
                cmd->duplex = DUPLEX_FULL;