projects / GitHub / moto-9609 / android_kernel_motorola_exynos9610.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 986eb9f)
staging/xgifb: Fix always false condition in vb_setmode.c (smatch)
authorPeter Huewe <peterhuewe@gmx.de>
Mon, 13 May 2013 21:41:49 +0000 (23:41 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 16 May 2013 23:02:35 +0000 (16:02 -0700)
Smatch complains:
drivers/staging/xgifb/vb_setmode.c:3181
XGI_SetLockRegs() warn: bitwise AND condition is false here

Since SetNTSCTV is defined as 0 in drivers/video/sis/initdef.h this is
correct.
-> Change the condition to == to fix this.

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/xgifb/vb_setmode.c patch | blob | blame | history

diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
index 3adec3f184621153fa0cae6fce7ea08a7f087175..5fb699dd1c4c8cd96f9ee47f1b6fbc86b57735af 100644 (file)
--- a/drivers/staging/xgifb/vb_setmode.c
+++ b/drivers/staging/xgifb/vb_setmode.c
@@ -3178,7 +3178,7 @@ static void XGI_SetLockRegs(unsigned short ModeNo, unsigned short ModeIdIndex,
        if (pVBInfo->VBInfo & SetCRT2ToTV) {
                if (pVBInfo->TVInfo & TVSimuMode) {
                        if (ModeNo == 0x50) {
-                               if (pVBInfo->TVInfo & SetNTSCTV) {
+                               if (pVBInfo->TVInfo == SetNTSCTV) {
                                        xgifb_reg_set(pVBInfo->Part1Port,
                                                        0x07, 0x30);
                                        xgifb_reg_set(pVBInfo->Part1Port,