r8169: fix an if condition
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 19 Sep 2014 10:40:25 +0000 (13:40 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 22 Sep 2014 19:19:17 +0000 (15:19 -0400)
There is an extra semi-colon so __rtl8169_set_features() is called every
time.

Fixes: 929a031dfd62 ('r8169: adjust __rtl8169_set_features')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Hayes Wang <hayeswang@realtek.com>--
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/realtek/r8169.c

index ef2cee5de62b2b1d8da91e7ef5719c7a7f4103e6..0921302553c6f09f871e8932a0c19e804de61189 100644 (file)
@@ -1818,7 +1818,7 @@ static int rtl8169_set_features(struct net_device *dev,
        features &= NETIF_F_RXALL | NETIF_F_RXCSUM | NETIF_F_HW_VLAN_CTAG_RX;
 
        rtl_lock_work(tp);
-       if (features ^ dev->features);
+       if (features ^ dev->features)
                __rtl8169_set_features(dev, features);
        rtl_unlock_work(tp);