drm/nouveau: Handle drm_atomic_helper_swap_state failure
authorMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
Tue, 11 Jul 2017 14:33:05 +0000 (16:33 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 26 Jul 2017 11:22:41 +0000 (13:22 +0200)
drm_atomic_helper_swap_state() will be changed to interruptible waiting
in the next few commits, so all drivers have to be changed to handling
failure.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Ben Skeggs <bskeggs@redhat.com>
Cc: nouveau@lists.freedesktop.org
Link: http://patchwork.freedesktop.org/patch/msgid/20170711143314.2148-4-maarten.lankhorst@linux.intel.com
Reviewed-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/nouveau/nv50_display.c

index c1e7307a253806113ae520b0aa72bc8c375f251e..747c99c1e474ef5b1b6663d4c087d0fc0fe89e64 100644 (file)
@@ -4123,6 +4123,10 @@ nv50_disp_atomic_commit(struct drm_device *dev,
                        goto err_cleanup;
        }
 
+       ret = drm_atomic_helper_swap_state(state, true);
+       if (ret)
+               goto err_cleanup;
+
        for_each_plane_in_state(state, plane, plane_state, i) {
                struct nv50_wndw_atom *asyw = nv50_wndw_atom(plane_state);
                struct nv50_wndw *wndw = nv50_wndw(plane);
@@ -4136,7 +4140,6 @@ nv50_disp_atomic_commit(struct drm_device *dev,
                }
        }
 
-       drm_atomic_helper_swap_state(state, true);
        drm_atomic_state_get(state);
 
        if (nonblock)