Staging: hv: blkvsc_drv: Cleanup the blkvsc_drv_exit() function
authorK. Y. Srinivasan <kys@microsoft.com>
Fri, 13 May 2011 02:34:44 +0000 (19:34 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 17 May 2011 19:27:09 +0000 (12:27 -0700)
To conform to the Linux device model, the device should persist even
when there is no driver bound to it. Cleanup the blkvsc_drv_exit() routine
keeping this in mind.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com>
Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/hv/blkvsc_drv.c

index 3c1637f2c27d9c585c44ada3f7967dbdf29222ab..46daade7a9e2c40935fc04ee0774d1cee66d3dc4 100644 (file)
@@ -833,42 +833,11 @@ static int blkvsc_drv_init(void)
        return ret;
 }
 
-static int blkvsc_drv_exit_cb(struct device *dev, void *data)
-{
-       struct device **curr = (struct device **)data;
-       *curr = dev;
-       return 1; /* stop iterating */
-}
 
 static void blkvsc_drv_exit(void)
 {
-       struct hv_driver *drv = &blkvsc_drv;
-       struct device *current_dev;
-       int ret;
-
-       while (1) {
-               current_dev = NULL;
-
-               /* Get the device */
-               ret = driver_for_each_device(&drv->driver, NULL,
-                                            (void *) &current_dev,
-                                            blkvsc_drv_exit_cb);
-
-               if (ret)
-                       DPRINT_WARN(BLKVSC_DRV,
-                                   "driver_for_each_device returned %d", ret);
-
-
-               if (current_dev == NULL)
-                       break;
-
-               /* Initiate removal from the top-down */
-               device_unregister(current_dev);
-       }
-
-       vmbus_child_driver_unregister(&drv->driver);
 
-       return;
+       vmbus_child_driver_unregister(&blkvsc_drv.driver);
 }
 
 /*