[POWERPC] Invert null match behaviour for irq_hosts
authorMichael Ellerman <michael@ellerman.id.au>
Tue, 28 Aug 2007 08:47:55 +0000 (18:47 +1000)
committerPaul Mackerras <paulus@samba.org>
Thu, 13 Sep 2007 15:33:20 +0000 (01:33 +1000)
Currently if you don't specify a match callback for your irq_host it's
assumed you match everything. This is a kind of opt-out approach, and
turns out to be the exception rather than the rule.

So change the semantics to be opt-in, ie. you don't match anything unless
you provide a match callback.  This in itself isn't very useful, but will
allow us to provide a default match implementation in a subsequent patch.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Paul Mackerras <paulus@samba.org>
arch/powerpc/kernel/irq.c
arch/powerpc/platforms/celleb/interrupt.c
arch/powerpc/platforms/iseries/irq.c
arch/powerpc/platforms/ps3/interrupt.c

index 79b451247b89a459ae0fe8c03460087f567be9a0..30fb8e2c5c9dff847fa6defb009ad6391ed6fb88 100644 (file)
@@ -523,7 +523,7 @@ struct irq_host *irq_find_host(struct device_node *node)
         */
        spin_lock_irqsave(&irq_big_lock, flags);
        list_for_each_entry(h, &irq_hosts, link)
-               if (h->ops->match == NULL || h->ops->match(h, node)) {
+               if (h->ops->match != NULL && h->ops->match(h, node)) {
                        found = h;
                        break;
                }
index 4ecdf06e421b4c599a479768cc55dfdc7ffcaaa4..c7c68ca70c82a321b3eaba1175ab0cb22a12eb8d 100644 (file)
@@ -175,11 +175,18 @@ static int beatic_pic_host_xlate(struct irq_host *h, struct device_node *ct,
        return 0;
 }
 
+static int beatic_pic_host_match(struct irq_host *h, struct device_node *np)
+{
+       /* Match all */
+       return 1;
+}
+
 static struct irq_host_ops beatic_pic_host_ops = {
        .map = beatic_pic_host_map,
        .remap = beatic_pic_host_remap,
        .unmap = beatic_pic_host_unmap,
        .xlate = beatic_pic_host_xlate,
+       .match = beatic_pic_host_match,
 };
 
 /*
index 36667460c922370f330b9b8944b27951b0c30cff..701d9297c207fac27848f1b96a2d9ceaa083d5cd 100644 (file)
@@ -346,8 +346,15 @@ static int iseries_irq_host_map(struct irq_host *h, unsigned int virq,
        return 0;
 }
 
+static int iseries_irq_host_match(struct irq_host *h, struct device_node *np)
+{
+       /* Match all */
+       return 1;
+}
+
 static struct irq_host_ops iseries_irq_host_ops = {
        .map = iseries_irq_host_map,
+       .match = iseries_irq_host_match,
 };
 
 /*
index 30b9f4c6eb5503ef6d4063fd05e9666b86dfefcd..3a6db04aa9405a87d7098a41c945a77ba950f143 100644 (file)
@@ -673,9 +673,16 @@ static int ps3_host_map(struct irq_host *h, unsigned int virq,
        return 0;
 }
 
+static int ps3_host_match(struct irq_host *h, struct device_node *np)
+{
+       /* Match all */
+       return 1;
+}
+
 static struct irq_host_ops ps3_host_ops = {
        .map = ps3_host_map,
        .unmap = ps3_host_unmap,
+       .match = ps3_host_match,
 };
 
 void __init ps3_register_ipi_debug_brk(unsigned int cpu, unsigned int virq)