ideapad-laptop: Blacklist rfkill control on the Lenovo Yoga 2 11
authorHans de Goede <hdegoede@redhat.com>
Tue, 13 May 2014 14:00:28 +0000 (16:00 +0200)
committerMatthew Garrett <matthew.garrett@nebula.com>
Tue, 10 Jun 2014 23:11:06 +0000 (19:11 -0400)
The Lenovo Yoga 2 11 always reports everything as blocked, causing userspace
to not even try to use the wlan / bluetooth even though they work fine.

Note this patch also removes the "else priv->rfk[i] = NULL;" bit of the
rfkill initialization, it is not necessary as the priv struct is allocated
with kzalloc.

Reported-and-tested-by: Vincent Gerris <vgerris@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Matthew Garrett <matthew.garrett@nebula.com>
drivers/platform/x86/ideapad-laptop.c

index 6dd060a0bb65293d47a2d02669a62785403b8ae0..219eb289a909cd40698ba97780094f6c2396babe 100644 (file)
@@ -36,6 +36,7 @@
 #include <linux/debugfs.h>
 #include <linux/seq_file.h>
 #include <linux/i8042.h>
+#include <linux/dmi.h>
 
 #define IDEAPAD_RFKILL_DEV_NUM (3)
 
@@ -819,6 +820,19 @@ static void ideapad_acpi_notify(acpi_handle handle, u32 event, void *data)
        }
 }
 
+/* Blacklist for devices where the ideapad rfkill interface does not work */
+static struct dmi_system_id rfkill_blacklist[] = {
+       /* The Lenovo Yoga 2 11 always reports everything as blocked */
+       {
+               .ident = "Lenovo Yoga 2 11",
+               .matches = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo Yoga 2 11"),
+               },
+       },
+       {}
+};
+
 static int ideapad_acpi_add(struct platform_device *pdev)
 {
        int ret, i;
@@ -854,11 +868,10 @@ static int ideapad_acpi_add(struct platform_device *pdev)
        if (ret)
                goto input_failed;
 
-       for (i = 0; i < IDEAPAD_RFKILL_DEV_NUM; i++) {
-               if (test_bit(ideapad_rfk_data[i].cfgbit, &priv->cfg))
-                       ideapad_register_rfkill(priv, i);
-               else
-                       priv->rfk[i] = NULL;
+       if (!dmi_check_system(rfkill_blacklist)) {
+               for (i = 0; i < IDEAPAD_RFKILL_DEV_NUM; i++)
+                       if (test_bit(ideapad_rfk_data[i].cfgbit, &priv->cfg))
+                               ideapad_register_rfkill(priv, i);
        }
        ideapad_sync_rfk_state(priv);
        ideapad_sync_touchpad_state(priv);