hwmon: (asus_atk0110) Remove useless kfree
authorPeter Senna Tschudin <peter.senna@gmail.com>
Wed, 12 Sep 2012 15:06:42 +0000 (17:06 +0200)
committerGuenter Roeck <linux@roeck-us.net>
Mon, 24 Sep 2012 04:08:35 +0000 (21:08 -0700)
The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
position p1,p2;
expression x;
@@

if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; }

@unchanged exists@
position r.p1,r.p2;
expression e <= r.x,x,e1;
iterator I;
statement S;
@@

if (x@p1 == NULL) { ... when != I(x,...) S
                        when != e = e1
                        when != e += e1
                        when != e -= e1
                        when != ++e
                        when != --e
                        when != e++
                        when != e--
                        when != &e
   kfree@p2(x); ... return ...; }

@ok depends on unchanged exists@
position any r.p1;
position r.p2;
expression x;
@@

... when != true x@p1 == NULL
kfree@p2(x);

@depends on !ok && unchanged@
position r.p2;
expression x;
@@

*kfree@p2(x);
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/asus_atk0110.c

index 4ee5789487233dbe6bf03920fa29fb820d366b8d..cccb0e9d45b46562d090065e5e65d6d9e48c2811 100644 (file)
@@ -962,7 +962,6 @@ static int atk_add_sensor(struct atk_data *data, union acpi_object *obj)
 
        return 1;
 out:
-       kfree(sensor->acpi_name);
        kfree(sensor);
        return err;
 }