drivers: libata-core: Use usleep_range() instead of msleep() for short sleeps (<20 ms)
authorAnil Veliyankara Madam <aveliyan@cisco.com>
Fri, 8 Jan 2016 05:18:52 +0000 (21:18 -0800)
committerTejun Heo <tj@kernel.org>
Fri, 8 Jan 2016 15:36:57 +0000 (10:36 -0500)
Since msleep() may sleep longer than intended time for values less
than 20ms, this patch allows the use of usleep_range for waits less
that 20ms. usleep_range is a finer precision implementation of
msleep and is designed to be a drop-in replacement for udelay
where a precise sleep/busy-wait is unnecessary.

More details can be found at http://lkml.org/lkml/2007/8/3/250
and in Documentation/timers/timers-howto.txt.

This change has been done to improve the performace in PIO6 mode
which is used by viking flash.

Cc: xe-kernel@external.cisco.com
Signed-off-by: Anil Veliyankara Madam <aveliyan@cisco.com>
Signed-off-by: Shikha Jain <shikjain@cisco.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
drivers/ata/libata-core.c

index 60e368610c749d5476d7e05b53d1f9351db8322e..f5ae6f43b65970ff2966fcf48acacfaad50947e2 100644 (file)
@@ -50,6 +50,7 @@
 #include <linux/blkdev.h>
 #include <linux/delay.h>
 #include <linux/timer.h>
+#include <linux/time.h>
 #include <linux/interrupt.h>
 #include <linux/completion.h>
 #include <linux/suspend.h>
@@ -6704,7 +6705,12 @@ void ata_msleep(struct ata_port *ap, unsigned int msecs)
        if (owns_eh)
                ata_eh_release(ap);
 
-       msleep(msecs);
+       if (msecs < 20) {
+               unsigned long usecs = msecs * USEC_PER_MSEC;
+               usleep_range(usecs, usecs + 50);
+       } else {
+               msleep(msecs);
+       }
 
        if (owns_eh)
                ata_eh_acquire(ap);