gpio: tz1090: Fix error handling of irq_of_parse_and_map
authorDmitry Torokhov <dtor@chromium.org>
Fri, 14 Nov 2014 21:32:56 +0000 (13:32 -0800)
committerLinus Walleij <linus.walleij@linaro.org>
Thu, 27 Nov 2014 13:34:47 +0000 (14:34 +0100)
irq_of_parse_and_map() returns 0 on error, so testing for negative
result never works.

Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Acked-by: James Hogan <james.hogan@imgtec.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-tz1090.c

index 5246a60eff6d83cb770e3cbe4951c80ebb6f5e29..6107d0682fd6d240a04f161adb741008176e7b40 100644 (file)
@@ -446,7 +446,7 @@ static int tz1090_gpio_bank_probe(struct tz1090_gpio_bank_info *info)
        bank->irq = irq_of_parse_and_map(np, 0);
 
        /* The interrupt is optional (it may be used by another core on chip) */
-       if (bank->irq < 0) {
+       if (!bank->irq) {
                dev_info(dev, "IRQ not provided for bank %u, IRQs disabled\n",
                         info->index);
                return 0;