NFS: Fix the XDR iovec calculation in nfs3_xdr_setaclargs
authorTrond Myklebust <Trond.Myklebust@netapp.com>
Mon, 20 Apr 2009 18:58:35 +0000 (14:58 -0400)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 21 Apr 2009 14:46:49 +0000 (07:46 -0700)
Commit ae46141ff08f1965b17c531b571953c39ce8b9e2 (NFSv3: Fix posix ACL code)
introduces a bug in the calculation of the XDR header iovec. In the case
where we are inlining the acls, we need to adjust the length of the iovec
req->rq_svec, in addition to adjusting the total buffer length.

Tested-by: Leonardo Chiquitto <leonardo.lists@gmail.com>
Tested-by: Suresh Jayaraman <sjayaraman@suse.de>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/nfs/nfs3xdr.c

index e6a1932c7110a245d77b0595d7ad57778ee3aad6..35869a4921f19e8c3ad3a273c28defabbf16283a 100644 (file)
@@ -713,7 +713,8 @@ nfs3_xdr_setaclargs(struct rpc_rqst *req, __be32 *p,
        if (args->npages != 0)
                xdr_encode_pages(buf, args->pages, 0, args->len);
        else
-               req->rq_slen += args->len;
+               req->rq_slen = xdr_adjust_iovec(req->rq_svec,
+                               p + XDR_QUADLEN(args->len));
 
        err = nfsacl_encode(buf, base, args->inode,
                            (args->mask & NFS_ACL) ?