drm/ttm: call driver move_notify() when doing system->tt bo moves
authorBen Skeggs <bskeggs@redhat.com>
Wed, 2 Feb 2011 00:27:10 +0000 (00:27 +0000)
committerDave Airlie <airlied@redhat.com>
Wed, 23 Feb 2011 01:09:24 +0000 (11:09 +1000)
Nouveau doesn't have enough information at ttm_backend_func.bind() time
to implement things like tiled GART, or to keep a buffer at a constant
address in the GPU virtual address space no matter where in physical
memory it's placed.

To resolve this, nouveau will handle binding of all buffers to the GPU
itself from the move_notify() hook.  This commit ensures it's called
for all buffer moves.

Talked to Dave about the impact on radeon, which uses move_notify, it
doesn't look like anything should break there.

Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
Reviewed-by: Thomas Hellstrom <thomas@shipmail.org>
Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/gpu/drm/ttm/ttm_bo.c

index af61fc29e843e3d0dabd8269118fdf3d69385171..0b6a55ac2f871c8c16f6cb4e62bbcad312eb6c57 100644 (file)
@@ -406,11 +406,12 @@ static int ttm_bo_handle_move_mem(struct ttm_buffer_object *bo,
                }
 
                if (bo->mem.mem_type == TTM_PL_SYSTEM) {
+                       if (bdev->driver->move_notify)
+                               bdev->driver->move_notify(bo, mem);
                        bo->mem = *mem;
                        mem->mm_node = NULL;
                        goto moved;
                }
-
        }
 
        if (bdev->driver->move_notify)