drivers/net/wimax/i2400m/fw.c: fix error return code
authorJulia Lawall <Julia.Lawall@lip6.fr>
Thu, 16 Aug 2012 21:46:56 +0000 (21:46 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 20 Aug 2012 09:33:21 +0000 (02:33 -0700)
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier ret;
expression e1,e2;
@@

if (ret < 0)
 { ... return ret; }
 ... when != ret = e1
     when forall
*if(...)
 {
  ... when != ret = e2
* return ret;
 }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wimax/i2400m/fw.c

index 283237f6f074a775b5ce82d6db1a64459168cfaf..def12b38cbf7002d27b83253c3be238e7e7f0802 100644 (file)
@@ -326,8 +326,10 @@ int i2400m_barker_db_init(const char *_options)
                unsigned barker;
 
                options_orig = kstrdup(_options, GFP_KERNEL);
-               if (options_orig == NULL)
+               if (options_orig == NULL) {
+                       result = -ENOMEM;
                        goto error_parse;
+               }
                options = options_orig;
 
                while ((token = strsep(&options, ",")) != NULL) {