mlxsw: spectrum: fix some error handling

The "err = " assignment is missing here.

Fixes: 0d65fc13042f ('mlxsw: spectrum: Implement LAG port join/leave')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
index 3ec07b9a458df1e1ca4132a626762d0a0bd626b8..322ed544348f09a75073400ec5eefbc5f6b4270f 100644 (file)
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
@@ -2091,7 +2091,7 @@ static int mlxsw_sp_port_lag_leave(struct mlxsw_sp_port *mlxsw_sp_port,
        err = mlxsw_sp_lag_col_port_disable(mlxsw_sp_port, lag_id);
        if (err)
                return err;
-       mlxsw_sp_lag_col_port_remove(mlxsw_sp_port, lag_id);
+       err = mlxsw_sp_lag_col_port_remove(mlxsw_sp_port, lag_id);
        if (err)
                return err;