V4L/DVB (7285): em28xx: Correct use of ! and &
authorJulia Lawall <julia@diku.dk>
Tue, 26 Feb 2008 23:43:56 +0000 (20:43 -0300)
committerMauro Carvalho Chehab <mchehab@infradead.org>
Thu, 20 Mar 2008 15:39:00 +0000 (12:39 -0300)
In commit e6bafba5b4765a5a252f1b8d31cbf6d2459da337, a bug was fixed that
involved converting !x & y to !(x & y).  The code below shows the same
pattern, and thus should perhaps be fixed in the same way.

This is not tested and clearly changes the semantics, so it is only
something to consider.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@ expression E1,E2; @@
(
  !E1 & !E2
|
- !E1 & E2
+ !(E1 & E2)
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
drivers/media/video/em28xx/em28xx-core.c

index 7d1537cab8679f03d8fc4188fd1a2bfe9642e247..8630ee09adddc4179f2482dc64f8e44cf1c10a4d 100644 (file)
@@ -267,7 +267,7 @@ static int em28xx_write_ac97(struct em28xx *dev, u8 reg, u8 *val)
        for (i = 0; i < 10; i++) {
                if ((ret = em28xx_read_reg(dev, AC97BUSY_REG)) < 0)
                        return ret;
-               if (!((u8) ret) & 0x01)
+               if (!(((u8)ret) & 0x01))
                        return 0;
                msleep(5);
        }