net: ipv6: Use BUG_ON
authorHimangi Saraogi <himangi774@gmail.com>
Fri, 11 Jul 2014 20:25:38 +0000 (01:55 +0530)
committerDavid S. Miller <davem@davemloft.net>
Fri, 11 Jul 2014 22:06:38 +0000 (15:06 -0700)
The semantic patch that makes the transformation is as follows:

// <smpl>
@@ expression e; @@
-if (e) BUG();
+BUG_ON(e);
// </smpl>

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/raw.c

index b2dc60b0c76403d38a6a96c8a1c299977ecb7bad..dee80fb1aa86299e34b2671e93cca036bb7ff3ee 100644 (file)
@@ -588,8 +588,7 @@ static int rawv6_push_pending_frames(struct sock *sk, struct flowi6 *fl6,
        }
 
        offset += skb_transport_offset(skb);
-       if (skb_copy_bits(skb, offset, &csum, 2))
-               BUG();
+       BUG_ON(skb_copy_bits(skb, offset, &csum, 2));
 
        /* in case cksum was not initialized */
        if (unlikely(csum))
@@ -601,8 +600,7 @@ static int rawv6_push_pending_frames(struct sock *sk, struct flowi6 *fl6,
        if (csum == 0 && fl6->flowi6_proto == IPPROTO_UDP)
                csum = CSUM_MANGLED_0;
 
-       if (skb_store_bits(skb, offset, &csum, 2))
-               BUG();
+       BUG_ON(skb_store_bits(skb, offset, &csum, 2));
 
 send:
        err = ip6_push_pending_frames(sk);