ath6kl: Remove unneeded memset in roam related config func
authorRaja Mani <rmani@qca.qualcomm.com>
Mon, 28 May 2012 06:21:12 +0000 (11:51 +0530)
committerKalle Valo <kvalo@qca.qualcomm.com>
Tue, 29 May 2012 11:21:22 +0000 (14:21 +0300)
No need to clear requested memory after allocating new SKB
with help of ath6kl_wmi_get_new_buf(). This clear part is
already taken care in ath6kl_wmi_get_new_buf().

Found this on code review.

Signed-off-by: Raja Mani <rmani@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
drivers/net/wireless/ath/ath6kl/wmi.c

index 63dc4fd73c4ccc80555a939d8c9d100e4dff6bff..43bce9c8a86fad8154dea800e08c311dc3e60006 100644 (file)
@@ -743,7 +743,6 @@ int ath6kl_wmi_force_roam_cmd(struct wmi *wmi, const u8 *bssid)
                return -ENOMEM;
 
        cmd = (struct roam_ctrl_cmd *) skb->data;
-       memset(cmd, 0, sizeof(*cmd));
 
        memcpy(cmd->info.bssid, bssid, ETH_ALEN);
        cmd->roam_ctrl = WMI_FORCE_ROAM;
@@ -763,7 +762,6 @@ int ath6kl_wmi_set_roam_mode_cmd(struct wmi *wmi, enum wmi_roam_mode mode)
                return -ENOMEM;
 
        cmd = (struct roam_ctrl_cmd *) skb->data;
-       memset(cmd, 0, sizeof(*cmd));
 
        cmd->info.roam_mode = mode;
        cmd->roam_ctrl = WMI_SET_ROAM_MODE;