bcache: trace missed reading by cache_missed
authorTang Junhui <tang.junhui.linux@gmail.com>
Mon, 8 Oct 2018 12:41:08 +0000 (20:41 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 13 Nov 2018 19:14:45 +0000 (11:14 -0800)
commit 502b291568fc7faf1ebdb2c2590f12851db0ff76 upstream.

Missed reading IOs are identified by s->cache_missed, not the
s->cache_miss, so in trace_bcache_read() using trace_bcache_read
to identify whether the IO is missed or not.

Signed-off-by: Tang Junhui <tang.junhui.linux@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Coly Li <colyli@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/md/bcache/request.c

index 5b63afff46d583d1937a5359156e518b6ce8a9e6..69b336d8c05a7187b1ec5007e69ddbf4c6695967 100644 (file)
@@ -792,7 +792,7 @@ static void cached_dev_read_done_bh(struct closure *cl)
 
        bch_mark_cache_accounting(s->iop.c, s->d,
                                  !s->cache_missed, s->iop.bypass);
-       trace_bcache_read(s->orig_bio, !s->cache_miss, s->iop.bypass);
+       trace_bcache_read(s->orig_bio, !s->cache_missed, s->iop.bypass);
 
        if (s->iop.status)
                continue_at_nobarrier(cl, cached_dev_read_error, bcache_wq);