clocksource/drivers/sun5i: Fail gracefully when clock rate is unavailable
authorChen-Yu Tsai <wens@csie.org>
Thu, 10 Jan 2019 06:22:07 +0000 (14:22 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Jan 2020 09:24:17 +0000 (10:24 +0100)
[ Upstream commit e7e7e0d7beafebd11b0c065cd5fbc1e5759c5aab ]

If the clock tree is not fully populated when the timer-sun5i init code
is called, attempts to get the clock rate for the timer would fail and
return 0.

Make the init code for both clock events and clocksource check the
returned clock rate and fail gracefully if the result is 0, instead of
causing a divide by 0 exception later on.

Fixes: 4a59058f0b09 ("clocksource/drivers/sun5i: Refactor the current code")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/clocksource/timer-sun5i.c

index 4f87f3e76d8328ec6ca462882f873a51b2f72995..c3e96de525a2482389f0a3dd449e52684df52478 100644 (file)
@@ -201,6 +201,11 @@ static int __init sun5i_setup_clocksource(struct device_node *node,
        }
 
        rate = clk_get_rate(clk);
+       if (!rate) {
+               pr_err("Couldn't get parent clock rate\n");
+               ret = -EINVAL;
+               goto err_disable_clk;
+       }
 
        cs->timer.base = base;
        cs->timer.clk = clk;
@@ -274,6 +279,11 @@ static int __init sun5i_setup_clockevent(struct device_node *node, void __iomem
        }
 
        rate = clk_get_rate(clk);
+       if (!rate) {
+               pr_err("Couldn't get parent clock rate\n");
+               ret = -EINVAL;
+               goto err_disable_clk;
+       }
 
        ce->timer.base = base;
        ce->timer.ticks_per_jiffy = DIV_ROUND_UP(rate, HZ);