projects / GitHub / LineageOS / android_kernel_motorola_exynos9610.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 511f3c5)
USB: gadget: net2280: remove leftover driver->unbind call in error pathway
authorAlan Stern <stern@rowland.harvard.edu>
Fri, 15 Mar 2013 18:03:17 +0000 (14:03 -0400)
committerFelipe Balbi <balbi@ti.com>
Wed, 20 Mar 2013 14:46:34 +0000 (16:46 +0200)
This patch (as1667) removes an incorrect driver->unbind() call from
the net2280 driver.  If startup fails, the UDC core takes care of
unbinding the gadget driver automatically; the controller driver
shouldn't do it too.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/gadget/net2280.c patch | blob | blame | history

diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c
index 3105a4d601c85a25870d073523d05fa228a765ce..3bd0f992fb49aebe5b5c4dc9e45356bb77c01581 100644 (file)
--- a/drivers/usb/gadget/net2280.c
+++ b/drivers/usb/gadget/net2280.c
@@ -1924,7 +1924,6 @@ static int net2280_start(struct usb_gadget *_gadget,
 err_func:
        device_remove_file (&dev->pdev->dev, &dev_attr_function);
 err_unbind:
-       driver->unbind (&dev->gadget);
        dev->gadget.dev.driver = NULL;
        dev->driver = NULL;
        return retval;