pnfs: fail comparison when bucket verifier not set

This skips the WARN_ON_ONCE, but doesnt change behavior (the memcmp would
fail).

Signed-off-by: Weston Andros Adamson <dros@primarydata.com>
Signed-off-by: Tom Haynes <Thomas.Haynes@primarydata.com>

diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c
index 651387bbfd9fac670e3f8f0b309046f26e24dd5e..eb814789f7002c0093da740a543e3a2393885fe2 100644 (file)
--- a/fs/nfs/direct.c
+++ b/fs/nfs/direct.c
@@ -222,7 +222,11 @@ static int nfs_direct_cmp_commit_data_verf(struct nfs_direct_req *dreq,
 
        verfp = nfs_direct_select_verf(dreq, data->ds_clp,
                                         data->ds_commit_index);
-       WARN_ON_ONCE(verfp->committed < 0);
+
+       /* verifier not set so always fail */
+       if (verfp->committed < 0)
+               return 1;
+
        return memcmp(verfp, &data->verf, sizeof(struct nfs_writeverf));
 }