drivers/rtc/rtc-efi.c: avoid subtracting day twice when computing year days
authorLee, Chun-Yi <joeyli.kernel@gmail.com>
Fri, 6 Jun 2014 21:35:48 +0000 (14:35 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 6 Jun 2014 23:08:07 +0000 (16:08 -0700)
Compared source code of rtc-lib.c::rtc_year_days() with
efirtc.c::rtc_year_days(), found the code in rtc-efi decreases value of
day twice when it computing year days.  rtc-lib.c::rtc_year_days() has
already decrease days and return the year days from 0 to 365.

Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/rtc/rtc-efi.c

index 797aa0252ba9adcd62fb765f46c8e8dfffc2c691..c4c38431012ecc5772209a2be69898feac968543 100644 (file)
@@ -35,7 +35,7 @@ static inline int
 compute_yday(efi_time_t *eft)
 {
        /* efi_time_t.month is in the [1-12] so, we need -1 */
-       return rtc_year_days(eft->day - 1, eft->month - 1, eft->year);
+       return rtc_year_days(eft->day, eft->month - 1, eft->year);
 }
 /*
  * returns day of the week [0-6] 0=Sunday