greybus: interface: remove unique id
authorJohan Hovold <johan@hovoldconsulting.com>
Sat, 21 Nov 2015 09:52:01 +0000 (10:52 +0100)
committerGreg Kroah-Hartman <gregkh@google.com>
Sun, 22 Nov 2015 01:15:35 +0000 (17:15 -0800)
Remove the unimplemented interface unique-id.

There will eventually be an interface-serial-number attribute provided,
but let's not export it or commit to a name for this attribute until we
need it.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
drivers/staging/greybus/Documentation/sysfs-bus-greybus
drivers/staging/greybus/interface.c
drivers/staging/greybus/interface.h
drivers/staging/greybus/manifest.c

index 22a0c7f5a9b3a78ad7c399ea98b1076cf5aef0b7..8363f2307049028cf994e1d63bdb4566d518b6d7 100644 (file)
@@ -107,13 +107,6 @@ Contact:   Greg Kroah-Hartman <greg@kroah.com>
 Description:
                Product ID string of a Greybus interface block.
 
-What:          /sys/bus/greybus/device/endoE:M:I/unique_id
-Date:          October 2015
-KernelVersion: 4.XX
-Contact:       Greg Kroah-Hartman <greg@kroah.com>
-Description:
-               Unique ID of a Greybus interface block.
-
 What:          /sys/bus/greybus/device/endoE:M:I/vendor
 Date:          October 2015
 KernelVersion: 4.XX
index 4c96adc56139da582da62307934365a9c4cb27cd..b57cc09d0f44cdff2fdf48cb29ad549cd3421b87 100644 (file)
@@ -23,7 +23,6 @@ static DEVICE_ATTR_RO(field)
 gb_interface_attr(device_id, d);
 gb_interface_attr(vendor, x);
 gb_interface_attr(product, x);
-gb_interface_attr(unique_id, llX);
 gb_interface_attr(vendor_string, s);
 gb_interface_attr(product_string, s);
 
@@ -31,7 +30,6 @@ static struct attribute *interface_attrs[] = {
        &dev_attr_device_id.attr,
        &dev_attr_vendor.attr,
        &dev_attr_product.attr,
-       &dev_attr_unique_id.attr,
        &dev_attr_vendor_string.attr,
        &dev_attr_product_string.attr,
        NULL,
index 248c9918a9cc7512f603f8deafccac7f782e6819..f0ef4e9a620607b90291ddbeb6703005e3b69655 100644 (file)
@@ -26,7 +26,6 @@ struct gb_interface {
        u16 product;
        char *vendor_string;
        char *product_string;
-       u64 unique_id;
 
        /* Information taken from the hotplug event */
        u32 unipro_mfg_id;
index 084e07e195c02478b3c10b766f43bc69acab8a27..4b4dd9973c17c589d445503f8612845425021b57 100644 (file)
@@ -396,7 +396,6 @@ static bool gb_manifest_parse_interface(struct gb_interface *intf,
        // Vendor, Product and Unique id must come via control protocol
        intf->vendor = 0xffff;
        intf->product = 0x0001;
-       intf->unique_id = 0;
 
        /* Release the interface descriptor, now that we're done with it */
        release_manifest_descriptor(interface_desc);