ceph: remove bogus invalidate_mapping_pages
authorSage Weil <sage@newdream.net>
Wed, 10 Feb 2010 00:43:11 +0000 (16:43 -0800)
committerSage Weil <sage@newdream.net>
Thu, 11 Feb 2010 19:48:55 +0000 (11:48 -0800)
We were invalidating mapping pages when dropping FILE_CACHE in
__send_cap().  But ceph_check_caps attempts to invalidate already, and
also checks for success, so we should never get to this point.

Signed-off-by: Sage Weil <sage@newdream.net>
fs/ceph/caps.c

index 20b28dc0c97c7c7bf5cbe8e94bc958fce69077c7..ab9b571dda1105e87e01708b05a885b489daa2cc 100644 (file)
@@ -1137,12 +1137,6 @@ static int __send_cap(struct ceph_mds_client *mdsc, struct ceph_cap *cap,
 
        spin_unlock(&inode->i_lock);
 
-       if (dropping & CEPH_CAP_FILE_CACHE) {
-               /* invalidate what we can */
-               dout("invalidating pages on %p\n", inode);
-               invalidate_mapping_pages(&inode->i_data, 0, -1);
-       }
-
        ret = send_cap_msg(session, ceph_vino(inode).ino, cap_id,
                op, keep, want, flushing, seq, flush_tid, issue_seq, mseq,
                size, max_size, &mtime, &atime, time_warp_seq,