Staging: hv: mousevsc: Fixup some bogus WARN_ON() calls
authorK. Y. Srinivasan <kys@microsoft.com>
Thu, 29 Sep 2011 18:54:43 +0000 (11:54 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 4 Oct 2011 17:39:31 +0000 (10:39 -0700)
Fix the bogus WARN_ON() calls.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/hv/hv_mouse.c

index 69eb00e45f8b871230cb2cdae947d868838c77bc..016d7e570d1cb5f47dc6de8594f4c3b19d7656e1 100644 (file)
@@ -200,7 +200,7 @@ static struct mousevsc_dev *alloc_input_device(struct hv_device *device)
 
 static void free_input_device(struct mousevsc_dev *device)
 {
-       WARN_ON(atomic_read(&device->ref_count) == 0);
+       WARN_ON(atomic_read(&device->ref_count) != 0);
        kfree(device);
 }
 
@@ -327,7 +327,7 @@ static void mousevsc_on_receive_device_info(struct mousevsc_dev *input_device,
 
        /* Save the hid desc */
        desc = &device_info->hid_descriptor;
-       WARN_ON(desc->bLength > 0);
+       WARN_ON(desc->bLength == 0);
 
        input_device->hid_desc = kzalloc(desc->bLength, GFP_KERNEL);
 
@@ -447,7 +447,7 @@ static void mousevsc_on_receive(struct hv_device *device,
                break;
 
        case SynthHidInitialDeviceInfo:
-               WARN_ON(pipe_msg->size >= sizeof(struct hv_input_dev_info));
+               WARN_ON(pipe_msg->size < sizeof(struct hv_input_dev_info));
 
                /*
                 * Parse out the device info into device attr,