drm/exynos: remove superfluous error messages
authorTobias Jakobi <tjakobi@math.uni-bielefeld.de>
Mon, 6 Apr 2015 23:14:51 +0000 (01:14 +0200)
committerInki Dae <inki.dae@samsung.com>
Mon, 13 Apr 2015 02:39:40 +0000 (11:39 +0900)
The messages are redundant since 'check_fb_gem_memory_type'
already prints out exactly the same string when it fails.

Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
Acked-by: Joonyoung Shim <jy0922.shim@samsung.com>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
drivers/gpu/drm/exynos/exynos_drm_fb.c

index d346d1e6eda03775e63d6ad7f969a1e1a9f4431d..929cb03a8eab15d6daee766016dc59070130a240 100644 (file)
@@ -151,10 +151,8 @@ exynos_drm_framebuffer_init(struct drm_device *dev,
        exynos_gem_obj = to_exynos_gem_obj(obj);
 
        ret = check_fb_gem_memory_type(dev, exynos_gem_obj);
-       if (ret < 0) {
-               DRM_ERROR("cannot use this gem memory type for fb.\n");
-               return ERR_PTR(-EINVAL);
-       }
+       if (ret < 0)
+               return ERR_PTR(ret);
 
        exynos_fb = kzalloc(sizeof(*exynos_fb), GFP_KERNEL);
        if (!exynos_fb)
@@ -250,10 +248,8 @@ exynos_user_fb_create(struct drm_device *dev, struct drm_file *file_priv,
                exynos_fb->exynos_gem_obj[i] = exynos_gem_obj;
 
                ret = check_fb_gem_memory_type(dev, exynos_gem_obj);
-               if (ret < 0) {
-                       DRM_ERROR("cannot use this gem memory type for fb.\n");
+               if (ret < 0)
                        goto err_unreference;
-               }
        }
 
        ret = drm_framebuffer_init(dev, &exynos_fb->fb, &exynos_drm_fb_funcs);