mfd: twl4030-irq: Pass the IRQF_ONESHOT flag
authorFabio Estevam <fabio.estevam@freescale.com>
Sat, 16 May 2015 18:42:10 +0000 (15:42 -0300)
committerLee Jones <lee.jones@linaro.org>
Mon, 22 Jun 2015 11:25:23 +0000 (12:25 +0100)
Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
bogus threaded irq requests") threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request will fail.

So pass the IRQF_ONESHOT flag in this case.

The semantic patch that makes this change is available
in scripts/coccinelle/misc/irqf_oneshot.cocci.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/twl4030-irq.c

index 1b772ef761cbf63cf1af01a32f9d720258214669..a3fa7f4f1fb4d8ca142e2a22d4081c8494c37cab 100644 (file)
@@ -674,7 +674,7 @@ int twl4030_sih_setup(struct device *dev, int module, int irq_base)
        irq_set_handler_data(irq, agent);
        agent->irq_name = kasprintf(GFP_KERNEL, "twl4030_%s", sih->name);
        status = request_threaded_irq(irq, NULL, handle_twl4030_sih,
-                                     IRQF_EARLY_RESUME,
+                                     IRQF_EARLY_RESUME | IRQF_ONESHOT,
                                      agent->irq_name ?: sih->name, NULL);
 
        dev_info(dev, "%s (irq %d) chaining IRQs %d..%d\n", sih->name,