net: sctp: Deletion of an unnecessary check before the function call "kfree"
authorMarkus Elfring <elfring@users.sourceforge.net>
Sat, 31 Jan 2015 17:10:03 +0000 (18:10 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 3 Feb 2015 03:29:43 +0000 (19:29 -0800)
The kfree() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-By: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/associola.c

index 26d06dbcc1c8e137798be5071848990fe00a7fe6..197c3f59ecbf1d7975a987e57c13023ac9e2b357 100644 (file)
@@ -391,8 +391,7 @@ void sctp_association_free(struct sctp_association *asoc)
        sctp_asconf_queue_teardown(asoc);
 
        /* Free pending address space being deleted */
-       if (asoc->asconf_addr_del_pending != NULL)
-               kfree(asoc->asconf_addr_del_pending);
+       kfree(asoc->asconf_addr_del_pending);
 
        /* AUTH - Free the endpoint shared keys */
        sctp_auth_destroy_keys(&asoc->endpoint_shared_keys);