net/ibm/emac: fix type of phy_mode
authorAndrzej Hajda <a.hajda@samsung.com>
Mon, 21 Sep 2015 13:33:50 +0000 (15:33 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 22 Sep 2015 23:14:31 +0000 (16:14 -0700)
phy_mode can be negative.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ibm/emac/core.h

index 28df37420da963d5d8f3b3234e4f584442537121..f379e474ba7ccd3eb9193e2d376d70727ab19594 100644 (file)
@@ -181,7 +181,7 @@ struct emac_instance {
        struct mal_commac               commac;
 
        /* PHY infos */
-       u32                             phy_mode;
+       int                             phy_mode;
        u32                             phy_map;
        u32                             phy_address;
        u32                             phy_feat_exc;