usb: dwc3: pci: fix failure path in dwc3_pci_probe()
authorPaul Zimmerman <Paul.Zimmerman@synopsys.com>
Sat, 25 Feb 2012 01:32:14 +0000 (17:32 -0800)
committerFelipe Balbi <balbi@ti.com>
Fri, 2 Mar 2012 10:12:07 +0000 (12:12 +0200)
dwc3_pci_probe() would return success even if the calls to
dwc3_get_device_id() or platform_device_alloc() fail, fix that.

Signed-off-by: Paul Zimmerman <paulz@synopsys.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/dwc3/dwc3-pci.c

index 74bac06652c45185acfa90f4eb85cbbf0f17a8e4..dcc64791b4e15ff1cd75035de5f784f34b29202b 100644 (file)
@@ -81,8 +81,10 @@ static int __devinit dwc3_pci_probe(struct pci_dev *pci,
        pci_set_master(pci);
 
        devid = dwc3_get_device_id();
-       if (devid < 0)
+       if (devid < 0) {
+               ret = -ENOMEM;
                goto err1;
+       }
 
        dwc3 = platform_device_alloc("dwc3", devid);
        if (!dwc3) {