regulator: core: Drop regulator_list_mutex when we're done with it on remove
authorMark Brown <broonie@kernel.org>
Fri, 7 Aug 2015 12:00:35 +0000 (13:00 +0100)
committerMark Brown <broonie@kernel.org>
Fri, 7 Aug 2015 12:03:20 +0000 (13:03 +0100)
When removing a regulator we hold regulator_list_mutex in order to
ensure the regualtor doesn't become removed again.  However we only need
to protect the list until we remove the regulator from the list so move
the unlock earlier to reduce the locked region.

Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/core.c

index 68b616580533f7500e20fb47071c4e83b7aa93d3..62e4f3bd57830b8b5b79b62c78ae8e600d3bcd83 100644 (file)
@@ -3827,11 +3827,11 @@ void regulator_unregister(struct regulator_dev *rdev)
        WARN_ON(rdev->open_count);
        unset_regulator_supplies(rdev);
        list_del(&rdev->list);
+       mutex_unlock(&regulator_list_mutex);
        kfree(rdev->constraints);
        regulator_ena_gpio_free(rdev);
        of_node_put(rdev->dev.of_node);
        device_unregister(&rdev->dev);
-       mutex_unlock(&regulator_list_mutex);
 }
 EXPORT_SYMBOL_GPL(regulator_unregister);