projects / GitHub / LineageOS / G12 / android_kernel_amlogic_linux-4.9.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 56411c0)
[media] stk1160: Check return value of stk1160_read_reg() in stk1160_i2c_read_reg()
authorJesper Juhl <jj@chaosbits.net>
Fri, 12 Oct 2012 22:16:37 +0000 (19:16 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Sun, 28 Oct 2012 18:41:54 +0000 (16:41 -0200)
Remember to collect the exit status from 'stk1160_read_reg()' in 'rc'
before testing it for less than zero.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: Ezequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/usb/stk1160/stk1160-i2c.c patch | blob | blame | history

diff --git a/drivers/media/usb/stk1160/stk1160-i2c.c b/drivers/media/usb/stk1160/stk1160-i2c.c
index 176ac937306be7e63b6362ae55f071adde7f00c0..850cf285ada8d97e2f2348da39f139d041d6404b 100644 (file)
--- a/drivers/media/usb/stk1160/stk1160-i2c.c
+++ b/drivers/media/usb/stk1160/stk1160-i2c.c
@@ -116,7 +116,7 @@ static int stk1160_i2c_read_reg(struct stk1160 *dev, u8 addr,
        if (rc < 0)
                return rc;
 
-       stk1160_read_reg(dev, STK1160_SBUSR_RD, value);
+       rc = stk1160_read_reg(dev, STK1160_SBUSR_RD, value);
        if (rc < 0)
                return rc;