gpio: adp5588: Use devm_gpiochip_add_data() for gpio registration
authorLaxman Dewangan <ldewangan@nvidia.com>
Mon, 22 Feb 2016 12:13:28 +0000 (17:43 +0530)
committerLaxman Dewangan <ldewangan@nvidia.com>
Tue, 23 Feb 2016 15:04:24 +0000 (20:34 +0530)
Use devm_gpiochip_add_data() for GPIO registration and remove the
call for gpiochip_remove() from remove callback.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Michael Hennerich <michael.hennerich@analog.com>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
drivers/gpio/gpio-adp5588.c

index 19a0eba1e942a2f652ff1c43f5b870512e82d698..c0f718b12317271d90c44ab73438f993c36a343e 100644 (file)
@@ -414,7 +414,7 @@ static int adp5588_gpio_probe(struct i2c_client *client,
                }
        }
 
-       ret = gpiochip_add_data(&dev->gpio_chip, dev);
+       ret = devm_gpiochip_add_data(&client->dev, &dev->gpio_chip, dev);
        if (ret)
                goto err_irq;
 
@@ -457,8 +457,6 @@ static int adp5588_gpio_remove(struct i2c_client *client)
        if (dev->irq_base)
                free_irq(dev->client->irq, dev);
 
-       gpiochip_remove(&dev->gpio_chip);
-
        return 0;
 }