drm/i915: return actual brightness to .get_brightness callback
authorJani Nikula <jani.nikula@intel.com>
Tue, 12 Mar 2013 09:44:16 +0000 (11:44 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 27 Mar 2013 20:06:08 +0000 (21:06 +0100)
The backlight device .get_brightness callback is supposed to return the
actual brightness by querying the hardware, not the cached value. See
Documentation/ABI/stable/sysfs-class-backlight. The callback is there to
support the actual_brightness sysfs file.

With the backlight_level and backlight device brightness now in sync, one
can reliably get the cached value through the brightness sysfs file.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_panel.c

index 00f367af77906f97b5ff300a7c0433a501f6fe8a..21f415ad80a3418d815dbb31047c8bc1585b19b4 100644 (file)
@@ -415,8 +415,7 @@ static int intel_panel_update_status(struct backlight_device *bd)
 static int intel_panel_get_brightness(struct backlight_device *bd)
 {
        struct drm_device *dev = bl_get_data(bd);
-       struct drm_i915_private *dev_priv = dev->dev_private;
-       return dev_priv->backlight_level;
+       return intel_panel_get_backlight(dev);
 }
 
 static const struct backlight_ops intel_panel_bl_ops = {