pcmcia: use kstrdup() in pcmcia_device_query()

Use kstrdup instead of kmalloc and strncpy.

Signed-off-by: Geliang Tang <geliangtang@163.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/pcmcia/ds.c b/drivers/pcmcia/ds.c
index 0decee6c556e88c8f9bb30fd6f604f69c89d50f0..489ea1098c96170ad532a636bf93a148b1228a97 100644 (file)
--- a/drivers/pcmcia/ds.c
+++ b/drivers/pcmcia/ds.c
@@ -468,12 +468,10 @@ static int pcmcia_device_query(struct pcmcia_device *p_dev)
                        if ((length < 2) || (length > 255))
                                continue;
 
-                       new = kmalloc(sizeof(char) * length, GFP_KERNEL);
+                       new = kstrdup(tmp, GFP_KERNEL);
                        if (!new)
                                continue;
 
-                       new = strncpy(new, tmp, length);
-
                        tmp = p_dev->prod_id[i];
                        p_dev->prod_id[i] = new;
                        kfree(tmp);