dma: sh: Don't use ENODEV for failing slave lookup
authorGuennadi Liakhovetski <g.liakhovetski@gmx.de>
Wed, 28 Nov 2012 06:49:47 +0000 (06:49 +0000)
committerVinod Koul <vinod.koul@intel.com>
Tue, 8 Jan 2013 06:05:06 +0000 (22:05 -0800)
If dmaengine driver's .device_alloc_chan_resources() method returns -ENODEV,
dma_request_channel() will decide, that the driver has been removed and will
remove the device from its list. To prevent this use ENXIO if a slave lookup
fails.

Reported-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: stable@vger.kernel.org
Signed-off-by: Vinod Koul <vinod.koul@linux.intel.com>
drivers/dma/sh/shdma.c

index 8201bb4e0cd7f74397bf1bd4d0960d4ed6cb9a6e..62eff48005210be4e93c1df0ff3301bde43676ec 100644 (file)
@@ -326,7 +326,7 @@ static int sh_dmae_set_slave(struct shdma_chan *schan,
                                                    shdma_chan);
        const struct sh_dmae_slave_config *cfg = dmae_find_slave(sh_chan, slave_id);
        if (!cfg)
-               return -ENODEV;
+               return -ENXIO;
 
        if (!try)
                sh_chan->config = cfg;