projects
/
GitHub
/
exynos8895
/
android_kernel_samsung_universal8895.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
d6e0a2d
)
mfd: ab8500-debugfs: Move dereference after check for NULL
author
Dan Carpenter
<dan.carpenter@oracle.com>
Wed, 13 Nov 2013 07:40:30 +0000
(10:40 +0300)
committer
Lee Jones
<lee.jones@linaro.org>
Mon, 6 Jan 2014 09:13:17 +0000
(09:13 +0000)
We dereference "desc" before check if it is NULL. I've shifted it
around so we check first before dereferencing.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/ab8500-debugfs.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/mfd/ab8500-debugfs.c
b/drivers/mfd/ab8500-debugfs.c
index e33e385af0a29e7930e4277984c640a1cf1db975..d1a22aae2df51cda0936a52dc58e9df66c493f7d 100644
(file)
--- a/
drivers/mfd/ab8500-debugfs.c
+++ b/
drivers/mfd/ab8500-debugfs.c
@@
-1600,7
+1600,6
@@
static int ab8500_interrupts_print(struct seq_file *s, void *p)
for (line = 0; line < num_interrupt_lines; line++) {
struct irq_desc *desc = irq_to_desc(line + irq_first);
- struct irqaction *action = desc->action;
seq_printf(s, "%3i: %6i %4i", line,
num_interrupts[line],
@@
-1608,7
+1607,9
@@
static int ab8500_interrupts_print(struct seq_file *s, void *p)
if (desc && desc->name)
seq_printf(s, "-%-8s", desc->name);
- if (action) {
+ if (desc && desc->action) {
+ struct irqaction *action = desc->action;
+
seq_printf(s, " %s", action->name);
while ((action = action->next) != NULL)
seq_printf(s, ", %s", action->name);